Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][media] Add summary and description to media routes #41

Merged
merged 2 commits into from
Nov 17, 2020
Merged

[docs][media] Add summary and description to media routes #41

merged 2 commits into from
Nov 17, 2020

Conversation

fe51
Copy link
Member

@fe51 fe51 commented Nov 17, 2020 •
edited
Loading

This PR aims at adding summary and description to the media routes.

All routes have a brief summary and brief description

image

image

@fe51 fe51 added topic: docs Improvements or additions to documentation endpoint: media labels Nov 17, 2020
@fe51 fe51 added this to the 0.1.0 milestone Nov 17, 2020
@fe51 fe51 self-assigned this Nov 17, 2020
@frgfm frgfm mentioned this pull request Nov 17, 2020
Closed
9 tasks
@codecov
Copy link

codecov bot commented Nov 17, 2020 •
edited
Loading

Codecov Report

Merging #41 (d54665b) into master (aaecd67) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          18       18           
  Lines         529      529           
=======================================
  Hits          469      469           
  Misses         60       60
Flag Coverage Δ
unittests 88.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/api/routes/media.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaecd67...d54665b. Read the comment docs.

frgfm
frgfm reviewed Nov 17, 2020
View reviewed changes
src/app/api/routes/media.py Outdated Show resolved Hide resolved
frgfm
frgfm approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks again!

@fe51 fe51 merged commit 3bb950c into master Nov 17, 2020
@fe51 fe51 deleted the route-desc-media branch November 19, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frgfm frgfm frgfm approved these changes

Assignees

@fe51 fe51

Labels
endpoint: media topic: docs Improvements or additions to documentation
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fe51 @frgfm